Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiup: remove restriction for enable_tls #11421

Merged
merged 1 commit into from
Nov 24, 2022
Merged

tiup: remove restriction for enable_tls #11421

merged 1 commit into from
Nov 24, 2022

Conversation

shichun-0415
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 24, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 24, 2022
@shichun-0415 shichun-0415 added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-release-5.0 area/tiup Indicates that the Issue or PR belongs to the area of the TiUP tool. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. and removed missing-translation-status This PR does not have translation status info. labels Nov 24, 2022
@shichun-0415 shichun-0415 added the type/bugfix This PR fixes a bug. label Nov 24, 2022
Oreoxmt
Oreoxmt approved these changes Nov 24, 2022
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 24, 2022
@shichun-0415
Copy link
Contributor Author

/status LGT2

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Nov 24, 2022
@shichun-0415
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 16b5a94

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 24, 2022
@ti-chi-bot ti-chi-bot merged commit a1b9e60 into pingcap:master Nov 24, 2022
@shichun-0415 shichun-0415 deleted the enable-tls branch November 24, 2022 08:46
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 24, 2022
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11431.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 24, 2022
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11432.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 24, 2022
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11433.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 24, 2022
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11434.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 24, 2022
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11435.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11436.

This was referenced Nov 24, 2022
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11437.

ti-chi-bot added a commit that referenced this pull request Nov 24, 2022
@ti-chi-bot
tiup: remove restriction for enable_tls (#11421) (#11436)
4f9a149
ti-chi-bot added a commit that referenced this pull request Nov 24, 2022
@ti-chi-bot
tiup: remove restriction for enable_tls (#11421) (#11437)
cb5d094
ti-chi-bot added a commit that referenced this pull request Nov 24, 2022
@ti-chi-bot
tiup: remove restriction for enable_tls (#11421) (#11435)
d8d777c
ti-chi-bot added a commit that referenced this pull request Nov 24, 2022
@ti-chi-bot
tiup: remove restriction for enable_tls (#11421) (#11431)
30b83c2
ti-chi-bot added a commit that referenced this pull request Nov 24, 2022
@ti-chi-bot
tiup: remove restriction for enable_tls (#11421) (#11432)
d120317
ti-chi-bot added a commit that referenced this pull request Nov 24, 2022
@ti-chi-bot
tiup: remove restriction for enable_tls (#11421) (#11433)
218dd6e
ti-chi-bot added a commit that referenced this pull request Nov 24, 2022
@ti-chi-bot
tiup: remove restriction for enable_tls (#11421) (#11434)
20150d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@srstack srstack srstack approved these changes

Assignees
No one assigned
Labels
area/tiup Indicates that the Issue or PR belongs to the area of the TiUP tool. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shichun-0415 @ti-chi-bot @srstack @Oreoxmt