Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Golang version to 1.20 #13638

Merged
merged 3 commits into from
May 22, 2023
Merged

update Golang version to 1.20 #13638

merged 3 commits into from
May 22, 2023

Conversation

Oreoxmt
Copy link
Collaborator

@Oreoxmt Oreoxmt commented May 22, 2023 •
edited
Loading

What is changed, added or deleted? (Required)

Starting from v7.0.0, the Golang version required for compiling and running TiDB is 1.20 or later.

This PR updates the Golang version from 1.18.5 to 1.20 and applies to v7.0 and master.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Oreoxmt
update Golang version to 1.20
c29fb55 
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
@Oreoxmt Oreoxmt added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-release-7.0 labels May 22, 2023
@Oreoxmt Oreoxmt requested a review from jayl1e May 22, 2023 04:01
@Oreoxmt Oreoxmt self-assigned this May 22, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 22, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lilin90

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 22, 2023
@Oreoxmt Oreoxmt requested review from hawkingrei and lilin90 May 22, 2023 04:14
@jayl1e
Copy link

jayl1e commented May 22, 2023

/lgtm

@Oreoxmt
update golang version in docs
ff4dcdf 
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
@Oreoxmt Oreoxmt mentioned this pull request May 22, 2023
Merged
Oreoxmt
Oreoxmt commented May 22, 2023
View reviewed changes
pd-control.md Outdated Show resolved Hide resolved
lilin90
lilin90 approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 22, 2023
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented May 22, 2023

/remove-status LGT1
/status LGT2
/verify
/merge

@ti-chi-bot ti-chi-bot bot added the status/LGT2 Indicates that a PR has LGTM 2. label May 22, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 22, 2023

This pull request has been accepted and is ready to merge.

Commit hash: a3d250d

@ti-chi-bot ti-chi-bot bot added status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 22, 2023
@ti-chi-bot ti-chi-bot bot merged commit cc88813 into pingcap:master May 22, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request May 22, 2023
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.0: #13649.

ti-chi-bot bot pushed a commit that referenced this pull request May 23, 2023
@ti-chi-bot
update Golang version to 1.20 (#13638) (#13649)
62d1899
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 approved these changes

@jayl1e jayl1e jayl1e approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Oreoxmt @jayl1e @ti-chi-bot @hawkingrei @lilin90