Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the default value of feedback-probability #3895

Merged
merged 5 commits into from
Sep 14, 2020
Merged

Change the default value of feedback-probability #3895

merged 5 commits into from
Sep 14, 2020

Conversation

Joyinqin
Copy link
Contributor

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@ti-srebot ti-srebot added needs-cherry-pick-4.0 size/small Changes of a small size. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Sep 14, 2020
@ti-srebot
Copy link
Contributor

These labels are not found needs-cherry-pick-3.1 needs-cherry-pick-3.0 needs-cherry-pick-2.1.

@Joyinqin
Copy link
Contributor Author

/label needs-cherry-pick-3.1,needs-cherry-pick-3.0,needs-cherry-pick-2.1

@Joyinqin Joyinqin marked this pull request as ready for review September 14, 2020 04:48
@Joyinqin
Copy link
Contributor Author

/cc winoros, TomShawn

TomShawn
TomShawn reviewed Sep 14, 2020
View reviewed changes
statistics.md Outdated Show resolved Hide resolved
TomShawn
TomShawn approved these changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 14, 2020
@TomShawn TomShawn added require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. labels Sep 14, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit b7e5008 into pingcap:master Sep 14, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Sep 14, 2020
@Joyinqin @ti-srebot
cherry pick pingcap#3895 to release-2.1
cf7b79d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Sep 14, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-2.1 in PR #3901

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Sep 14, 2020
@Joyinqin @ti-srebot
cherry pick pingcap#3895 to release-3.0
a5b9198 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Sep 14, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 in PR #3902

TomShawn pushed a commit that referenced this pull request Sep 14, 2020
@ti-srebot @Joyinqin
cherry pick #3895 to release-2.1 (#3901)
0428f61 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: JoyinQ <56883733+Joyinqin@users.noreply.github.com>
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Sep 14, 2020
@Joyinqin @ti-srebot
cherry pick pingcap#3895 to release-3.1
09f965d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Sep 14, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-3.1 in PR #3903

TomShawn pushed a commit that referenced this pull request Sep 14, 2020
@ti-srebot @Joyinqin
cherry pick #3895 to release-3.0 (#3902)
3c5039d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: JoyinQ <56883733+Joyinqin@users.noreply.github.com>
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Sep 14, 2020
@Joyinqin @ti-srebot
cherry pick pingcap#3895 to release-4.0
eb35baf 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Sep 14, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3904

TomShawn pushed a commit that referenced this pull request Sep 14, 2020
@ti-srebot @Joyinqin
cherry pick #3895 to release-3.1 (#3903)
25891db 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: JoyinQ <56883733+Joyinqin@users.noreply.github.com>
ti-srebot added a commit that referenced this pull request Sep 14, 2020
@ti-srebot
Change the default value of feedback-probability (#3895) (#3904)
9e466bc 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@winoros winoros Awaiting requested review from winoros

Assignees
No one assigned
Labels
require-LGT1 Indicates that the PR requires an LGTM. size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Joyinqin @ti-srebot @TomShawn