Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the default GC scan lock mode back to LEGACY #5136

Merged
merged 4 commits into from
Mar 29, 2021
Merged

Update the default GC scan lock mode back to LEGACY #5136

merged 4 commits into from
Mar 29, 2021

Conversation

qiancai
Copy link
Collaborator

@qiancai qiancai commented Mar 26, 2021 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

This PR addresses the comments in pingcap/docs-cn#5856 made by @MyonKeminta: The default mode of the GC scan lock is still LEGACY in 5.0 GA.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 26, 2021
@qiancai
Copy link
Collaborator Author

qiancai commented Mar 26, 2021

/label v5.0

@ti-chi-bot ti-chi-bot added the v5.0 This PR/issue applies to TiDB v5.0. label Mar 26, 2021
@qiancai
Copy link
Collaborator Author

qiancai commented Mar 26, 2021

/label needs-cherry-pick-5.0

@qiancai
Copy link
Collaborator Author

qiancai commented Mar 26, 2021

/translation from-docs-cn

@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed missing-translation-status This PR does not have translation status info. labels Mar 26, 2021
@qiancai
Copy link
Collaborator Author

qiancai commented Mar 26, 2021

/cc @MyonKeminta @morgo

@ti-chi-bot ti-chi-bot requested review from morgo and MyonKeminta March 26, 2021 11:46
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 29, 2021
@morgo
Copy link
Contributor

morgo commented Mar 29, 2021

/LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 29, 2021
@qiancai
Copy link
Collaborator Author

qiancai commented Mar 29, 2021

/cc @TomShawn

@ti-chi-bot ti-chi-bot requested a review from TomShawn March 29, 2021 03:30
@TomShawn
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • morgo

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 29, 2021
@qiancai qiancai mentioned this pull request Mar 29, 2021
Merged
11 tasks
@TomShawn
Copy link
Contributor

/cc @MyonKeminta

MyonKeminta
MyonKeminta approved these changes Mar 29, 2021
View reviewed changes
Copy link
Contributor

@MyonKeminta MyonKeminta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@MyonKeminta: /lgtm is only allowed for the reviewers in list.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@yikeke
Copy link
Contributor

yikeke commented Mar 29, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9fc1bcf

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 29, 2021
@ti-chi-bot ti-chi-bot merged commit 6be2766 into pingcap:master Mar 29, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Mar 29, 2021
@qiancai @ti-srebot
cherry pick pingcap#5136 to release-5.0
70bfe88 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 29, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5146

ti-chi-bot pushed a commit that referenced this pull request Mar 29, 2021
@ti-srebot
Update the default GC scan lock mode back to LEGACY (#5136) (#5146)
5a98a32
@qiancai
Copy link
Collaborator Author

qiancai commented Mar 29, 2021

/cc @3pointer

@ti-chi-bot ti-chi-bot requested a review from 3pointer March 29, 2021 09:48
@bb7133 bb7133 mentioned this pull request Jun 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MyonKeminta MyonKeminta MyonKeminta approved these changes

@morgo morgo Awaiting requested review from morgo

@TomShawn TomShawn Awaiting requested review from TomShawn

@3pointer 3pointer Awaiting requested review from 3pointer

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v5.0 This PR/issue applies to TiDB v5.0.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@qiancai @morgo @TomShawn @ti-chi-bot @yikeke @ti-srebot @MyonKeminta