Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: remove some config fields for copr cache #5266

Merged
merged 3 commits into from
Apr 9, 2021
Merged

docs: remove some config fields for copr cache #5266

merged 3 commits into from
Apr 9, 2021

Conversation

Joyinqin
Copy link
Contributor

@Joyinqin Joyinqin commented Apr 8, 2021 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Fix the error in #5030.
remove enable part for copr cache.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 8, 2021
@Joyinqin
Copy link
Contributor Author

Joyinqin commented Apr 9, 2021

/translation from-docs-cn
/label needs-cherry-pick-5.0
/label v5.0

@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-5.0 v5.0 This PR/issue applies to TiDB v5.0. and removed missing-translation-status This PR does not have translation status info. labels Apr 9, 2021
@Joyinqin Joyinqin marked this pull request as ready for review April 9, 2021 02:01
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 9, 2021
@Joyinqin
Copy link
Contributor Author

Joyinqin commented Apr 9, 2021

/cc @ran-huang @TomShawn

@TomShawn
Copy link
Contributor

TomShawn commented Apr 9, 2021

@Joyinqin Please change the heading level in L515 from ### to ##.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 9, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Apr 9, 2021

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 9, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Apr 9, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 230534c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 9, 2021
@ti-chi-bot ti-chi-bot merged commit 53666a4 into pingcap:master Apr 9, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 9, 2021
@Joyinqin @ti-srebot
cherry pick pingcap#5266 to release-5.0
bafe820 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 9, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5272

ti-chi-bot pushed a commit that referenced this pull request Apr 9, 2021
@ti-srebot
docs: remove some config fields for copr cache (#5266) (#5272)
5f3fde5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ran-huang ran-huang ran-huang approved these changes

@TomShawn TomShawn Awaiting requested review from TomShawn

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v5.0 This PR/issue applies to TiDB v5.0.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Joyinqin @TomShawn @ti-chi-bot @ti-srebot @ran-huang