Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql-mode: remove 'full support' for 'PAD_CHAR_TO_FULL_LENGTH' #5646

Merged
merged 2 commits into from
May 19, 2021
Merged

sql-mode: remove 'full support' for 'PAD_CHAR_TO_FULL_LENGTH' #5646

merged 2 commits into from
May 19, 2021

Conversation

bb7133
Copy link
Member

@bb7133 bb7133 commented May 18, 2021

What is changed, added or deleted? (Required)

Update the support 'PAD_CHAR_TO_FULL_LENGTH', remove the 'full support' description due to pingcap/tidb#14007.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • None

@ti-chi-bot ti-chi-bot requested a review from TomShawn May 18, 2021 15:08
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 18, 2021
@bb7133
Copy link
Member Author

bb7133 commented May 18, 2021

/cc @morgo , I'm not sure if there's a better way to update it.

@TomShawn TomShawn requested a review from morgo May 19, 2021 03:09
@morgo
Copy link
Contributor

morgo commented May 19, 2021

/LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 19, 2021
TomShawn
TomShawn reviewed May 19, 2021
View reviewed changes
sql-mode.md Outdated Show resolved Hide resolved
TomShawn
TomShawn approved these changes May 19, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • morgo

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 19, 2021
@TomShawn TomShawn added needs-cherry-pick-release-3.0 translation/doing This PR's assignee is translating this PR. labels May 19, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label May 19, 2021
@bb7133 @TomShawn
Address comment: update sql-mode.md
3f39e1c 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3f39e1c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 19, 2021
@ti-chi-bot ti-chi-bot merged commit 3da3ae2 into pingcap:master May 19, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request May 19, 2021
Merged
6 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5649.

@ti-chi-bot ti-chi-bot mentioned this pull request May 19, 2021
Merged
6 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5650.

@ti-chi-bot ti-chi-bot mentioned this pull request May 19, 2021
Merged
6 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5651.

@ti-chi-bot ti-chi-bot mentioned this pull request May 19, 2021
Merged
6 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5652.

ti-chi-bot added a commit that referenced this pull request May 19, 2021
@ti-chi-bot
sql-mode: remove 'full support' for 'PAD_CHAR_TO_FULL_LENGTH' (#5646) (…
a03e4d1 
…#5651)
ti-chi-bot added a commit that referenced this pull request May 19, 2021
@ti-chi-bot
sql-mode: remove 'full support' for 'PAD_CHAR_TO_FULL_LENGTH' (#5646) (…
c708e48 
…#5652)
ti-chi-bot added a commit that referenced this pull request May 19, 2021
@ti-chi-bot
sql-mode: remove 'full support' for 'PAD_CHAR_TO_FULL_LENGTH' (#5646) (…
b5330f9 
…#5650)
ti-chi-bot added a commit that referenced this pull request May 19, 2021
@ti-chi-bot
sql-mode: remove 'full support' for 'PAD_CHAR_TO_FULL_LENGTH' (#5646) (…
32e66fc 
…#5649)
@Joyinqin Joyinqin mentioned this pull request May 19, 2021
Merged
11 tasks
@Joyinqin
Copy link
Contributor

/translation done
/remove-translation doing

@ti-chi-bot ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels May 19, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: failed to apply #5646 on top of branch "release-3.0":

failed to git commit: exit status 1

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: failed to apply #5646 on top of branch "release-3.1":

failed to git commit: exit status 1

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: failed to apply #5646 on top of branch "release-4.0":

failed to git commit: exit status 1

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: failed to apply #5646 on top of branch "release-5.0":

failed to git commit: exit status 1

This was referenced May 19, 2021
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@morgo morgo Awaiting requested review from morgo

Assignees

@Joyinqin Joyinqin

Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bb7133 @morgo @ti-chi-bot @TomShawn @Joyinqin