Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: add FLUSH PRIVILEGES hint #835

Merged
merged 6 commits into from
Jan 10, 2019
Merged

sql: add FLUSH PRIVILEGES hint #835

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a974894
Add FLUSH PRIVILEGES hint to user-account-management.md and FAQ.md
lastzero Jan 3, 2019
fd82671
FLUSH PRIVILEGES only required if grant table was modified
lastzero Jan 4, 2019
5a53161
Fix wording: grant tables
lastzero Jan 4, 2019
71db930
Change wording as requested
lastzero Jan 9, 2019
fde876e
Change link as requested
lastzero Jan 9, 2019
2111b84
Use backticks to format title as code
CaitinChen Jan 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions sql/user-account-management.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,3 +93,13 @@ Or:
```sql
ALTER USER 'jeffrey'@'localhost' IDENTIFIED BY 'mypass';
```

## Flush privileges
lastzero marked this conversation as resolved.
Show resolved Hide resolved

If you modified the grant tables directly, please run the following command to apply changes immediately:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you modified the grant tables directly, please run the following command to apply changes immediately:
If you modified the grant tables directly, run the following command to apply changes immediately:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually do not use "please" in technical documents.


```sql
FLUSH PRIVILEGES;
```

See [Privilege Management](privilege.md) for details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
See [Privilege Management](privilege.md) for details.
For details, see [Privilege Management](../sql/privilege.md).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is ../sql/ a mistake? Both documents are in sql, so ../sql is the same directory.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lastzero No, ../sql/ is not a mistake. Your link path is correct on GitHub, but on the PingCAP website it will be a broken link.
Our link rule: Any relative path that links to another file must start from the level of the root directory.
We updated the link path rule for SEO. Thanks for your cooperation :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. You use pandoc, right? In my own projects, MkDocs automatically creates the right links in HTML as needed.

Copy link
Contributor

@CaitinChen CaitinChen Jan 24, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lastzero We do use pandoc to convert HTML to PDF, but it has nothing to do with our links in the documents.
We have our own link rule because of the complex hierarchical relationship in our website.