Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewriter,restorer: add the DO NOT EDIT comment to the generated Go code #42

Closed
wants to merge 2 commits into from

Conversation

kennytm
Copy link
Contributor

@kennytm kennytm commented Jun 29, 2019

What problem does this PR solve?

Fix #37.

What is changed and how it works?

This is a resubmission of #39 which puts the comment at the end of the file.

Check List

Tests

  • Unit test

Side effects

Related changes

@codecov
Copy link

codecov bot commented Jun 29, 2019

Codecov Report

Merging #42 into master will increase coverage by 0.3519%.
The diff coverage is 63.6363%.

@@               Coverage Diff                @@
##             master        #42        +/-   ##
================================================
+ Coverage   85.9183%   86.2702%   +0.3519%     
================================================
  Files             7          7                
  Lines           980        925        -55     
================================================
- Hits            842        798        -44     
+ Misses           85         80         -5     
+ Partials         53         47         -6     

@kennytm kennytm added the S:DNM label Jun 29, 2019
@kennytm
Copy link
Contributor Author

kennytm commented Jun 29, 2019

This PR is currently blocked by microsoft/vscode-go#2617. The VSCode Go extension only recognize the comment on the first line, so putting the comment at the end won't give us the read-only protection we want.

@CLAassistant
Copy link

CLAassistant commented Jul 2, 2020

CLA assistant check
All committers have signed the CLA.

@kennytm kennytm added S:PTAL and removed S:DNM labels Jul 2, 2020
@kennytm kennytm marked this pull request as ready for review July 2, 2020 11:27
@tisonkun
Copy link
Contributor

tisonkun commented Mar 9, 2022

@kennytm is this PR still valid and we can proceed it?

@tisonkun
Copy link
Contributor

Closed as #37 has been marked as resolved.

@tisonkun tisonkun closed this Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a "DO NOT EDIT" comment to failpoint-enabled source code
3 participants