Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tpcc: add wait times on each transactions #42

Merged
merged 4 commits into from
May 21, 2020
Merged

tpcc: add wait times on each transactions #42

merged 4 commits into from
May 21, 2020

Conversation

mahjonp
Copy link
Contributor

@mahjonp mahjonp commented May 20, 2020

Add Keying Time and Thinking Time between txn execution and two flags.

Usage:
  go-tpc tpcc run [flags]

Flags:
  -h, --help   help for run
      --wait   including keying & thinking time described on TPC-C Standard Specification

For example.

./bin/go-tpc tpcc --warehouses 4 run --wait

Signed-off-by: mahjonp <junpeng.man@gmail.com>
Signed-off-by: mahjonp <junpeng.man@gmail.com>
Signed-off-by: mahjonp <junpeng.man@gmail.com>
@zhouqiang-cl zhouqiang-cl requested a review from innerr May 20, 2020 12:47
@siddontang
Copy link
Member

I can't understand keying and thinking easily, can you use other words or refer to other TPCC implementation at first then think a better name?

@coocood
Copy link
Member

coocood commented May 21, 2020

LGTM

Signed-off-by: mahjonp <junpeng.man@gmail.com>
@mahjonp
Copy link
Contributor Author

mahjonp commented May 21, 2020

I can't understand keying and thinking easily, can you use other words or refer to other TPCC implementation at first then think a better name?

I combined them into one wait flag.

Copy link
Contributor

@zhouqiang-cl zhouqiang-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mahjonp mahjonp merged commit 3ed127b into master May 21, 2020
@mahjonp mahjonp deleted the wait_times branch May 21, 2020 03:17
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants