Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In-memory engine: add pre-load extra msg for pre-load when transfer leader #1270

Merged
merged 6 commits into from
Sep 18, 2024

Conversation

SpadeA-Tang
Copy link
Contributor

No description provided.

Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au>
@ti-chi-bot ti-chi-bot bot added the size/XL label Sep 18, 2024
Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au>
@SpadeA-Tang
Copy link
Contributor Author

@overvenus PTAL

Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@@ -255,6 +255,7 @@ enum ExtraMessageType {
// Messages for the snapshot gen precheck process.
MsgSnapGenPrecheckRequest = 15;
MsgSnapGenPrecheckResponse = 16;
MsgPreLoadRegionRequest = 17;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some comments.

Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au>
@SpadeA-Tang
Copy link
Contributor Author

PTAL @glorv

Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au>
Copy link

ti-chi-bot bot commented Sep 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glorv, overvenus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Sep 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-18 08:56:27.276802693 +0000 UTC m=+1037857.017226625: ☑️ agreed by overvenus.
  • 2024-09-18 09:39:44.550872624 +0000 UTC m=+1040454.291296565: ☑️ agreed by glorv.

@SpadeA-Tang
Copy link
Contributor Author

/merge

@glorv glorv merged commit 199f352 into pingcap:master Sep 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants