support cpp lang in kvproto
#375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hanfei1991
commented
Apr 3, 2019
•
hanfei1991
commented
- Support cpp lang.
- Add protos for learner sync.
- Add protos for communication between flash and spark.
This reverts commit d3a21c7.
Signed-off-by: nolouch <nolouch@gmail.com>
| @@ -12,3 +12,7 @@ Cargo.lock | |||
| .vscode | |||
| .idea | |||
| _tools | |||
|
|
|||
| cpp/kvproto/*.h | |||
| cpp/kvproto/*.cc | |||
There was a problem hiding this comment.
Why ignore cpp code?
There was a problem hiding this comment.
@flowbehappy I have the same question
There was a problem hiding this comment.
Because the cpp code generated by protobuf is likely unportable with other platform.
Is it necessary to put it in this repo? |
|
I've removed the flashpb in this repo. |
|
|
|
LGTM |
|
@overvenus PTAL |
overvenus
approved these changes
Apr 16, 2019
tiancaiamao
approved these changes
Apr 16, 2019
|
Can someone familiar with the API changes fix the broken code in TiKV side? |
youjiali1995
added a commit
to youjiali1995/kvproto
that referenced
this pull request
Apr 29, 2019
This reverts commit 894ab99.
sticnarf
pushed a commit
to sticnarf/kvproto
that referenced
this pull request
Oct 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.