tikvrpc: support batch split #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: disksing <i@disksing.com>
overvenus
reviewed
Aug 13, 2019
proto/kvrpcpb.proto
Outdated
| @@ -487,12 +487,14 @@ message MvccGetByStartTsResponse { | |||
| message SplitRegionRequest { | |||
| Context context = 1; | |||
| bytes split_key = 2; | |||
There was a problem hiding this comment.
Maybe we can change it repeated instead of adding a new filed.
There was a problem hiding this comment.
em, seems not a good idea. If new tidb connects to an old tikv, tikv will silently split the region into 2 with no error.
There was a problem hiding this comment.
Could you mark it deprecated?
|
Ping @overvenus @zimulala |
Signed-off-by: disksing <i@disksing.com>
overvenus
approved these changes
Aug 21, 2019
zimulala
approved these changes
Aug 21, 2019
disksing
added a commit
that referenced
this pull request
Sep 16, 2019
sticnarf
pushed a commit
to sticnarf/kvproto
that referenced
this pull request
Oct 27, 2019
Signed-off-by: disksing <i@disksing.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: disksing i@disksing.com