Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backup: add GCS proto (#514) #525

Merged
merged 2 commits into from
Dec 12, 2019
Merged

Conversation

SunRunAway
Copy link
Contributor

cherry-pick #514 to release-3.1


part of pingcap/br#89

GCS Support (1800 points)

Extend backup protobuf to support GCS

@SunRunAway SunRunAway requested review from kennytm, overvenus and tennix and removed request for kennytm December 12, 2019 06:01
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please generate rust code by make rust.

Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm merged commit 373b0fe into pingcap:release-3.1 Dec 12, 2019
@SunRunAway SunRunAway deleted the cherry-pick-3.1 branch December 12, 2019 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants