Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mydumper: added flag to toggle _tidb_rowid; disabled by default #9

Merged
merged 1 commit into from
Nov 1, 2018

Conversation

kennytm
Copy link

@kennytm kennytm commented Nov 1, 2018

We don't want to generate _tidb_rowid unless very special circumstances (e.g. restore a full backup to a brand new TiDB cluster). The _tidb_rowid option now hidden behind a flag --tidb-rowid and is disabled by default.

@kennytm
Copy link
Author

kennytm commented Nov 1, 2018

@morgo @GregoryIan PTAL

cc pingcap/tidb#8126.

@IANTHEREAL
Copy link
Collaborator

LGTM

Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IANTHEREAL IANTHEREAL merged commit 21902f6 into master Nov 1, 2018
@IANTHEREAL IANTHEREAL deleted the kennytm/disable-tidb-rowid branch November 1, 2018 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants