*: fix string(int) issues for Go 1.15 compatibility #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make test will fail due to Go1.15 starts to not allow "string(int)" expression. Fix affected sources by replace such expression to legal expressions. More info about ban string(int), see: golang/go#3939
|
|
ti-srebot
approved these changes
Sep 5, 2020
wjhuang2016
changed the title
|
/run-all-tests |
|
@LENSHOOD merge failed. |
tiancaiamao
pushed a commit
to tiancaiamao/parser
that referenced
this pull request
Apr 27, 2021
Make test will fail due to Go1.15 starts to not allow "string(int)" expression. Fix affected sources by replace such expression to legal expressions. More info about ban string(int), see: golang/go#3939 Co-authored-by: ti-srebot <66930949+ti-srebot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Since Go 1.15, expression "string(int)" to make type casting from int to string are not allowed.
Check more info at golang/go#3939.
Run
make testat Go 1.15 env would lead to below error:./lexer_test.go:204:12: conversion from untyped int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)What is changed and how it works?
Replace such casting expressions to other legally expressions.