parser,ast: fix the TiDB issue #8153 #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eurekaka
reviewed
Nov 6, 2018
ast/expressions.go
Outdated
| return n, false | ||
| } | ||
| n.N = node.(ExprNode) | ||
| } | ||
| n = newNode.(*PositionExpr) |
There was a problem hiding this comment.
Put this line before the added check?
There was a problem hiding this comment.
Thank you for the comment. I've updated the PR.
There was a problem hiding this comment.
I mean like this:
n = newNode.(*PositionExpr)
if n.N != nil {
node, ok := n.N.Accept(v)
if !ok {
return n, false
}
n.N = node.(ExprNode)
}we should modify newNode.N instead of n.N?
There was a problem hiding this comment.
Thank you for the correction. I've updated the PR.
zz-jason
pushed a commit
that referenced
this pull request
Nov 8, 2018
tiancaiamao
pushed a commit
to tiancaiamao/parser
that referenced
this pull request
Apr 27, 2021
tiancaiamao
pushed a commit
to tiancaiamao/parser
that referenced
this pull request
Apr 27, 2021
lyonzhi
pushed a commit
to lyonzhi/parser
that referenced
this pull request
Apr 25, 2024
lyonzhi
pushed a commit
to lyonzhi/parser
that referenced
this pull request
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TiDB PR 8206 requires this PR.