-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parser: add support for show pump/drainer status
#217
Conversation
@WangXiangUSTC PTAL |
thanks @caohe |
go.mod1
Outdated
@@ -11,6 +11,7 @@ require ( | |||
github.com/pingcap/errors v0.11.0 | |||
github.com/pingcap/tidb v0.0.0-20190218065808-69472bd1a6e9 | |||
github.com/pingcap/tipb v0.0.0-20190107072121-abbec73437b7 | |||
github.com/pkg/errors v0.8.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems don't need this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. I have removed it.
@kennytm PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM sans the go.mod1
change.
parser.y
Outdated
jobs "JOBS" | ||
job "JOB" | ||
pump "PUMP" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please format this line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. PTAL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
Add support for
show pump/drainer status
#9201
What is changed and how it works?
Add pump and drainer to parser.y and dml.go
Check List
Tests
Code changes
Side effects
Related changes