Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: add support for show pump/drainer status #217

Merged
merged 2 commits into from
Feb 21, 2019

Conversation

caohe
Copy link
Contributor

@caohe caohe commented Feb 20, 2019

What problem does this PR solve?

Add support for show pump/drainer status
#9201

What is changed and how it works?

Add pump and drainer to parser.y and dml.go

Check List

Tests

  • Unit test

Code changes

  • Has interface methods change

Side effects

  • None

Related changes

  • None

@caohe
Copy link
Contributor Author

caohe commented Feb 20, 2019

@WangXiangUSTC PTAL

@WangXiangUSTC
Copy link
Contributor

thanks @caohe

go.mod1 Outdated
@@ -11,6 +11,7 @@ require (
github.com/pingcap/errors v0.11.0
github.com/pingcap/tidb v0.0.0-20190218065808-69472bd1a6e9
github.com/pingcap/tipb v0.0.0-20190107072121-abbec73437b7
github.com/pkg/errors v0.8.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems don't need this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I have removed it.

@WangXiangUSTC
Copy link
Contributor

@kennytm PTAL

Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM sans the go.mod1 change.

parser.y Outdated
jobs "JOBS"
job "JOB"
pump "PUMP"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please format this line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. PTAL

Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC WangXiangUSTC added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Feb 21, 2019
@WangXiangUSTC WangXiangUSTC merged commit f7d7526 into pingcap:master Feb 21, 2019
@caohe caohe deleted the pump_and_drainer branch February 21, 2019 06:25
WangXiangUSTC pushed a commit to WangXiangUSTC/parser that referenced this pull request Mar 25, 2019
WangXiangUSTC added a commit that referenced this pull request Mar 26, 2019
* parser: add support for show pump/drainer status  (#217)

* Support update pump or drainer status (#243)
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants