Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ast: add create role ast structure #219

Merged
merged 8 commits into from
Feb 28, 2019
Merged

Conversation

imtbkcat
Copy link

What problem does this PR solve?

add CREATE ROLE support by using CreateUserStmt.

What is changed and how it works?

add boolean variable IsCreateRole to distinct CREATE ROLE with CREATE USER.

Check List

Tests

  • Unit test

Code changes

  • Has exported variable/fields change

Side effects

Related changes

go.mod1 Outdated Show resolved Hide resolved
parser.y Outdated Show resolved Hide resolved
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added the status/LGT1 LGT1 label Feb 25, 2019
@tiancaiamao
Copy link
Collaborator

Is there a TiDB PR? @imtbkcat

@imtbkcat
Copy link
Author

@tiancaiamao yes, here is : pingcap/tidb#9461

@tiancaiamao
Copy link
Collaborator

LGTM

@tiancaiamao tiancaiamao added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Feb 27, 2019
@jackysp jackysp merged commit 74e8cff into pingcap:master Feb 28, 2019
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants