Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: fix Restore of FieldType in handling decimal #278

Closed
wants to merge 1 commit into from
Closed

types: fix Restore of FieldType in handling decimal #278

wants to merge 1 commit into from

Conversation

lonng
Copy link
Contributor

@lonng lonng commented Apr 9, 2019

Signed-off-by: Lonng chris@lonng.org

What problem does this PR solve?

Consider the following create table statement:

create table t(a decimal(20) not null);

If we parse it and restore it will get an unexpected result: create table t(a decimal not null).

The result should keep consistent with show create table t which emit create table t(a decimal(20, 0) not null)

What is changed and how it works?

Fix it

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

N/A

Side effects

N/A

Related changes

  • Need to cherry-pick to the release branch

Signed-off-by: Lonng <chris@lonng.org>
@lonng lonng added the type/bug-fix fix bug label Apr 9, 2019
@IANTHEREAL
Copy link

LGTM

@IANTHEREAL
Copy link

@tiancaiamao PTAL

@bb7133
Copy link
Member

bb7133 commented Apr 18, 2019

Please add some test cases, thanks!

@kennytm
Copy link
Contributor

kennytm commented May 29, 2019

(Fixed in #311 too)

@lonng
Copy link
Contributor Author

lonng commented May 29, 2019

Closed due to fixed in #311

@lonng lonng closed this May 29, 2019
@lonng lonng deleted the fix-ft-restore branch May 29, 2019 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants