Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stmtType to ast.Prepared to record metric #487

Merged
merged 4 commits into from
Aug 19, 2019
Merged

add stmtType to ast.Prepared to record metric #487

merged 4 commits into from
Aug 19, 2019

Conversation

lysu
Copy link
Collaborator

@lysu lysu commented Aug 15, 2019

What problem does this PR solve?

rel pingcap/tidb#11753

add stmtType in Prepared so we can calculate stmtType just in COM_PREPARE

What is changed and how it works?

RT

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • n/a

Side effects

  • n/a

Related changes

  • Need to cherry-pick to the release branch

This change is Reviewable

@codecov
Copy link

codecov bot commented Aug 16, 2019

Codecov Report

Merging #487 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #487      +/-   ##
==========================================
- Coverage   71.48%   71.44%   -0.04%     
==========================================
  Files          32       32              
  Lines        7672     7648      -24     
==========================================
- Hits         5484     5464      -20     
+ Misses       1667     1665       -2     
+ Partials      521      519       -2
Impacted Files Coverage Δ
ast/misc.go 74.05% <ø> (ø) ⬆️
ast/ddl.go 79.85% <0%> (-0.06%) ⬇️
parser.go 70.58% <0%> (ø) ⬆️
misc.go 96.42% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f9e53e...3d605d7. Read the comment docs.

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 LGT1 label Aug 16, 2019
@lysu lysu requested a review from tiancaiamao August 16, 2019 07:48
@lysu lysu requested review from cfzjywxk and imtbkcat August 16, 2019 08:56
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants