Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sysvar: error code for sysvar.go in tidb #634

Merged
merged 1 commit into from
Nov 11, 2019
Merged

sysvar: error code for sysvar.go in tidb #634

merged 1 commit into from
Nov 11, 2019

Conversation

cfzjywxk
Copy link
Contributor

What problem does this PR solve?

add the missing error code related using in sysvar.go in tidb

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

  • Has exported variable/fields change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to update the documentation
  • Need to be included in the release note

@cfzjywxk cfzjywxk requested review from lysu, jackysp, imtbkcat and a team November 11, 2019 11:02
@ghost ghost requested review from kennytm and removed request for a team November 11, 2019 11:02
@cfzjywxk cfzjywxk mentioned this pull request Nov 11, 2019
Merged
@cfzjywxk cfzjywxk added the type/enhancement New feature or request label Nov 11, 2019
bb7133
bb7133 reviewed Nov 11, 2019
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 added the status/LGT1 LGT1 label Nov 11, 2019
jackysp
jackysp approved these changes Nov 11, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jackysp
jackysp approved these changes Nov 11, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jackysp
jackysp approved these changes Nov 11, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp merged commit e3789d9 into pingcap:master Nov 11, 2019
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
@cfzjywxk @jackysp
error code for sysvar.go (pingcap#634)
9334402
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
@cfzjywxk @jackysp
error code for sysvar.go (pingcap#634)
f1d1f7a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 left review comments

@jackysp jackysp jackysp approved these changes

@lysu lysu Awaiting requested review from lysu

@imtbkcat imtbkcat Awaiting requested review from imtbkcat

@kennytm kennytm Awaiting requested review from kennytm

Assignees
No one assigned
Labels
status/LGT1 LGT1 type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cfzjywxk @bb7133 @jackysp