Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: cherry-pick #868, #856, #836, #855 to 4.0-itai #882

Merged
merged 5 commits into from
Jun 2, 2020
Merged

parser: cherry-pick #868, #856, #836, #855 to 4.0-itai #882

merged 5 commits into from
Jun 2, 2020

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Jun 1, 2020 •
edited
Loading

What problem does this PR solve?

cherry-pick:
support partition selection grammer for the delete statement (#868)
support the syntax insert into tbl_name partition (#856)
Fix set charset statement (#836)
support show table partition regions (#855)
to 4.0-itai

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

@AilinKid AilinKid changed the title parser: support partition selection grammer for the delete statement … parser: support partition selection grammer for the delete statement (#868) Jun 1, 2020
@codecov
Copy link

codecov bot commented Jun 1, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (4.0-itai@4c8a0b6). Click here to learn what that means.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             4.0-itai     #882   +/-   ##
===========================================
  Coverage            ?   78.20%           
===========================================
  Files               ?       40           
  Lines               ?    14671           
  Branches            ?        0           
===========================================
  Hits                ?    11474           
  Misses              ?     2514           
  Partials            ?      683

zimulala
zimulala reviewed Jun 1, 2020
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu @AilinKid
support the syntax insert into tbl_name partition (pingcap#856)
8f954bc 
* test

* support the syntax insert into tbl_name partition

* address comment
@AilinKid AilinKid changed the title parser: support partition selection grammer for the delete statement (#868) parser: cherry-pick #868, #856 to 4.0 itai Jun 1, 2020
AilinKid and others added 2 commits June 1, 2020 19:12
@AilinKid
.
00eb668 
Signed-off-by: AilinKid <314806019@qq.com>
@wjhuang2016 @AilinKid
Fix set charset statement (pingcap#836)
c3a59db
@AilinKid AilinKid changed the title parser: cherry-pick #868, #856 to 4.0 itai parser: cherry-pick #868, #856, #836 to 4.0 itai Jun 1, 2020
tangenta
tangenta approved these changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added the status/LGT2 LGT2 label Jun 1, 2020
@crazycs520 @AilinKid
support show table partition regions (pingcap#855)
b699cab 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@AilinKid AilinKid changed the title parser: cherry-pick #868, #856, #836 to 4.0 itai parser: cherry-pick #868, #856, #836, #855 to 4.0 itai Jun 2, 2020
@AilinKid AilinKid changed the title parser: cherry-pick #868, #856, #836, #855 to 4.0 itai parser: cherry-pick #868, #856, #836, #855 to 4.0-itai Jun 2, 2020
@AilinKid AilinKid merged commit 0f6ff1a into pingcap:4.0-itai Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala left review comments

@tangenta tangenta tangenta approved these changes

Assignees
No one assigned
Labels
status/LGT2 LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@AilinKid @zimulala @tangenta @kennytm @tiancaiamao @XuHuaiyu @wjhuang2016 @crazycs520