*: reimplement dynamic config #2349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rleungx
added
the
do-not-merge/work-in-progress
rleungx
force-pushed
the
reimplement
branch
4 times, most recently
from
dd67b77 to
b43b0f4
Compare
rleungx
added
component/pkg
and removed
do-not-merge/work-in-progress
|
/run-all-tests |
HunDunDM
reviewed
Apr 14, 2020
rleungx
force-pushed
the
reimplement
branch
2 times, most recently
from
ac3450c to
f5bc492
Compare
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
|
/run-all-tests |
Signed-off-by: Ryan Leung <rleungx@gmail.com>
overvenus
approved these changes
Apr 17, 2020
HunDunDM
reviewed
Apr 17, 2020
Signed-off-by: Ryan Leung <rleungx@gmail.com>
|
/merge |
sre-bot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for 2353 |
|
/run-all-tests |
|
@rleungx merge failed. |
|
/merge |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
What is changed and how it works?
This PR removes the original implementation and adds new APIs to register and get addresses of other components.
Release note
Remove
config managerto let other components control their configuration by themselvesCheck List
Tests