api: support input with a prefix when using config #2354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
rleungx
force-pushed
the
prefix-config
branch
3 times, most recently
from
f30b234 to
fddc382
Compare
|
/run-all-tests |
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
HunDunDM
approved these changes
Apr 21, 2020
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
@rleungx merge failed. |
|
/merge |
|
/run-all-tests |
|
@rleungx merge failed. |
|
/merge |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Currently, the input of JSON only supports like
{"schedule-region-limit":20}when using config API, but TiDB will send a JSON like{"schedule.schedule-region-limit":20}when using SQL to change the config. This PR can be reviewed after #2349 is merged.What is changed and how it works?
This PR support using the key like "xxx.xxx-xxx-xxx" when sending a JSON as an input.
Release note
Fix the issue that config API can not accept a config item with a prefix
Check List
Tests