Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: update the import path(release-3.0) #2779

Merged
merged 1 commit into from
Aug 24, 2020

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Aug 17, 2020

Signed-off-by: nolouch nolouch@gmail.com

What problem does this PR solve?

ref: #2758

  • update import path
  • cancel go mod v3

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Release note

  • change import path from pingcap/pd to tikv/pd

Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch nolouch added the component/build Build process. label Aug 17, 2020
@nolouch
Copy link
Contributor Author

nolouch commented Aug 17, 2020

/run-all-tests

@codecov
Copy link

codecov bot commented Aug 17, 2020

Codecov Report

Merging #2779 into release-3.0 will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-3.0    #2779      +/-   ##
===============================================
+ Coverage        69.72%   69.77%   +0.04%     
===============================================
  Files              171      171              
  Lines            16987    16987              
===============================================
+ Hits             11845    11853       +8     
+ Misses            4162     4153       -9     
- Partials           980      981       +1     
Impacted Files Coverage Δ
client/client.go 71.81% <ø> (ø)
pkg/metricutil/metricutil.go 94.44% <ø> (+8.33%) ⬆️
pkg/mock/mockclassifier/mockclassifier.go 30.00% <ø> (ø)
pkg/mock/mockcluster/mockcluster.go 90.68% <ø> (ø)
pkg/mock/mockhbstream/mockhbstream.go 85.71% <ø> (ø)
pkg/mock/mockoption/mockoption.go 92.77% <ø> (ø)
pkg/testutil/operator_check.go 83.33% <ø> (ø)
server/api/admin.go 64.70% <ø> (ø)
server/api/classifier.go 66.66% <ø> (ø)
server/api/cluster.go 75.00% <ø> (ø)
... and 103 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f91897...2cc126c. Read the comment docs.

@nolouch nolouch added this to the v3.0.19 milestone Aug 17, 2020
Copy link
Member

@HunDunDM HunDunDM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 17, 2020
Copy link
Member

@JmPotato JmPotato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@JmPotato,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: scheduling(slack).

@nolouch
Copy link
Contributor Author

nolouch commented Aug 24, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 24, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 1f26153 into tikv:release-3.0 Aug 24, 2020
@nolouch nolouch deleted the release-3.0 branch August 24, 2020 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/build Build process. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants