Skip to content
This repository has been archived by the owner on Jun 24, 2021. It is now read-only.

Update drainer config #745

Merged
merged 3 commits into from
Apr 30, 2019
Merged

Update drainer config #745

merged 3 commits into from
Apr 30, 2019

Conversation

liubo0127
Copy link
Contributor

@WangXiangUSTC
Copy link
Contributor

LGTM

@IANTHEREAL @liubo0127
Apply suggestions from code review
3ec9d83 
Co-Authored-By: liubo0127 <liubo@pingcap.com>
@CLAassistant
Copy link

CLAassistant commented Apr 28, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

superlzs0476
superlzs0476 approved these changes Apr 28, 2019
View reviewed changes
Copy link
Contributor

@superlzs0476 superlzs0476 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liubo0127 liubo0127 merged commit c4ea46d into pingcap:master Apr 30, 2019
@liubo0127 liubo0127 deleted the liubo/update-drainer-conf branch April 30, 2019 02:07
liubo0127 added a commit that referenced this pull request Apr 30, 2019
@liubo0127
Update drainer config (#745)
70399e4 
* Update drainer config

* Add new configuration items to binlog

* Apply suggestions from code review

Co-Authored-By: liubo0127 <liubo@pingcap.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IANTHEREAL IANTHEREAL IANTHEREAL left review comments

@superlzs0476 superlzs0476 superlzs0476 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@liubo0127 @WangXiangUSTC @CLAassistant @IANTHEREAL @superlzs0476