sysbench: add a 'insert ignore' bench test with unique indices #52
Conversation
| function event() | ||
| local table_name = "sbtest" .. sysbench.rand.uniform(1, sysbench.opt.tables) | ||
| local query = string.format("INSERT IGNORE INTO %s (id, k, c, pad) VALUES ", table_name) | ||
| for i = 1, 5 do |
There was a problem hiding this comment.
should we use a larger number, I think 5 is a bit small.
There was a problem hiding this comment.
This is not a prepared statement, if we use a lot of VALUES, the performance would be affected by the parser (the dominant time cost) and then the test can't reflect the truth.
5 is enough to cover insert ignore code and prevent the performance regression if a request visit TiKV multiple times.
There was a problem hiding this comment.
It is OK. Below 100 values, the effects of parser should be negligible. Also, you could also use the prepare statement.
There was a problem hiding this comment.
Also, you could also use the prepare statement.
emmmm... I'd like to but I'm not so familiar with Lua this bench framework... so just get things done
There was a problem hiding this comment.
How about adding a parameter: Eg, https://github.com/pingcap/productivity-tools/blob/master/benchmark/batch_insert/batch_insert.lua#L65
|
PTAL @mahjonp |
Benchmark for pingcap/tidb#12872
PTAL @jackysp