Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drainer/syncer: add configuration for read-timeout (#1061) #1066

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #1061

What problem does this PR solve?

When we meet some DDL that will cost a lot of time, readTimeout setting to 1m won't be enough.

What is changed and how it works?

add configuration for read-timeout in drainer configuration.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

Release note

  • Make ReadTimeout for sql.DB configurable by [syncer.to.read-timeout]

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Aug 10, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glorv
  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lichunzhu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 9fa142a

@dianqihanwangzi
Copy link

/run-unit-test

@lichunzhu
Copy link
Contributor

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit 679d62d into pingcap:release-5.1 Oct 13, 2021
lichunzhu pushed a commit to ti-chi-bot/tidb-binlog that referenced this pull request Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants