Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: fix drainer can't send request correctly to pump when set compressor=gzip #1186

Merged
merged 3 commits into from
Aug 16, 2022
Merged

*: fix drainer can't send request correctly to pump when set compressor=gzip #1186

merged 3 commits into from
Aug 16, 2022

Conversation

lichunzhu
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #1152

What is changed and how it works?

See #1152 (comment), add 4MB buffer for max grpc message size.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    Test playground with compressor, works correctly.

Related changes

  • Need to cherry-pick to the release branch

Release note

  • fix drainer can't send request correctly to pump when set compressor=gzip

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 16, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hi-rustin
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@lichunzhu
Copy link
Contributor Author

/run-integration-test

@lichunzhu
Copy link
Contributor Author

/run-all-tests

Rustin170506
Rustin170506 approved these changes Aug 16, 2022
View reviewed changes
Copy link
Member

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about moving the comment above the code?

@ti-chi-bot ti-chi-bot added size/S and removed size/XS labels Aug 16, 2022
@lichunzhu
Copy link
Contributor Author

/run-all-tests

@lichunzhu
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f487527

@ti-chi-bot ti-chi-bot merged commit 9992784 into pingcap:master Aug 16, 2022
@lichunzhu lichunzhu deleted the fixDrainerGzip branch August 17, 2022 02:00
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1192.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/tidb-binlog#release-5.2 from head ti-chi-bot:cherry-pick-1186-to-release-5.2: the GitHub API request returns a 403 error: {"message":"You have exceeded a secondary rate limit and have been temporarily blocked from content creation. Please retry your request again later.","documentation_url":"https://docs.github.com/rest/overview/resources-in-the-rest-api#secondary-rate-limits"}

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: cannot checkout 5.4: error checking out 5.4: exit status 1. output: error: pathspec '5.4' did not match any file(s) known to git

ti-chi-bot pushed a commit to ti-chi-bot/tidb-binlog that referenced this pull request Aug 17, 2022
@lichunzhu @ti-chi-bot
This is an automated cherry-pick of pingcap#1186
70bf981 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit to ti-chi-bot/tidb-binlog that referenced this pull request Aug 17, 2022
@lichunzhu @ti-chi-bot
This is an automated cherry-pick of pingcap#1186
52aa2fb 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
This was referenced Aug 17, 2022
Merged
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1193.

@lichunzhu
Copy link
Contributor Author

/cherry-pick release-5.2
/cherry-pick release-5.3
/cherry-pick release-5.4
/cherry-pick release-6.0
/cherry-pick release-6.1

ti-chi-bot pushed a commit to ti-chi-bot/tidb-binlog that referenced this pull request Aug 17, 2022
@lichunzhu @ti-chi-bot
This is an automated cherry-pick of pingcap#1186
1fd1c0e 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 17, 2022
Merged
@ti-chi-bot
Copy link
Member

@lichunzhu: new pull request created: #1194.

In response to this:

/cherry-pick release-5.2
/cherry-pick release-5.3
/cherry-pick release-5.4
/cherry-pick release-6.0
/cherry-pick release-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb-binlog that referenced this pull request Aug 17, 2022
@lichunzhu @ti-chi-bot
This is an automated cherry-pick of pingcap#1186
6a4809c 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 17, 2022
Merged
@ti-chi-bot
Copy link
Member

@lichunzhu: new pull request created: #1195.

In response to this:

/cherry-pick release-5.2
/cherry-pick release-5.3
/cherry-pick release-5.4
/cherry-pick release-6.0
/cherry-pick release-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 17, 2022
Merged
@ti-chi-bot
Copy link
Member

@lichunzhu: new pull request created: #1196.

In response to this:

/cherry-pick release-5.2
/cherry-pick release-5.3
/cherry-pick release-5.4
/cherry-pick release-6.0
/cherry-pick release-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@lichunzhu: new pull request created: #1197.

In response to this:

/cherry-pick release-5.2
/cherry-pick release-5.3
/cherry-pick release-5.4
/cherry-pick release-6.0
/cherry-pick release-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

This was referenced Aug 17, 2022
Closed
Merged
@ti-chi-bot
Copy link
Member

@lichunzhu: new pull request created: #1198.

In response to this:

/cherry-pick release-5.2
/cherry-pick release-5.3
/cherry-pick release-5.4
/cherry-pick release-6.0
/cherry-pick release-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lichunzhu
Copy link
Contributor Author

/cherry-pick release-6.2

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 17, 2022
Closed
@ti-chi-bot
Copy link
Member

@lichunzhu: new pull request created: #1199.

In response to this:

/cherry-pick release-6.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot added a commit that referenced this pull request Aug 17, 2022
@ti-chi-bot
*: fix drainer can't send request correctly to pump when set compress…
2b5ded0 
…or=gzip (#1186) (#1192)

close #1152
ti-chi-bot added a commit that referenced this pull request Aug 17, 2022
@ti-chi-bot
*: fix drainer can't send request correctly to pump when set compress…
bebeb14 
…or=gzip (#1186) (#1195)

close #1152
ti-chi-bot added a commit that referenced this pull request Aug 17, 2022
@ti-chi-bot
*: fix drainer can't send request correctly to pump when set compress…
48c0f05 
…or=gzip (#1186) (#1196)

close #1152
ti-chi-bot added a commit that referenced this pull request Aug 18, 2022
@ti-chi-bot
*: fix drainer can't send request correctly to pump when set compress…
1997266 
…or=gzip (#1186) (#1191)

close #1152
ti-chi-bot added a commit that referenced this pull request Aug 18, 2022
@ti-chi-bot
*: fix drainer can't send request correctly to pump when set compress…
2e8bd50 
…or=gzip (#1186) (#1198)

close #1152
ti-chi-bot added a commit that referenced this pull request Aug 18, 2022
@ti-chi-bot
*: fix drainer can't send request correctly to pump when set compress…
1699f7b 
…or=gzip (#1186) (#1194)

close #1152
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rustin170506 Rustin170506 Rustin170506 approved these changes

@lance6716 lance6716 lance6716 approved these changes

@amyangfei amyangfei Awaiting requested review from amyangfei

@glorv glorv Awaiting requested review from glorv

Assignees
No one assigned
Labels
needs-cherry-pick-release-4.0 needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 Type: Need cherry pick to release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Type: Need cherry pick to release-5.4 size/S status/can-merge status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

drainer: can't send request correctly to pump when set compressor=gzip
4 participants
@lichunzhu @ti-chi-bot @lance6716 @Rustin170506