Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine case name and add split region test #711

Merged
merged 2 commits into from
Aug 15, 2019

Conversation

lichunzhu
Copy link
Contributor

@lichunzhu lichunzhu commented Aug 13, 2019

What problem does this PR solve?

This PR is a replication of #707. I accidentally forced push to my own branch so it closed...

  1. Refine case name in tests/dailytest/case.go similar to drainer: fix failure to update BIT columns with downstream TiDB when message passes through Kafka #667.
  2. update parser in go.mode & go.sum to tidb release 2.1 #705 updated parser which supported pre_split_regions. This PR add one test to test whether sql pre_split_regions can be parsed in binlog and synced to downstream.

What is changed and how it works?

Case name has been refactored and one more test about pre_split_regions is added. This test will create a table with pre_split_regions and try to insert some data.

Check List

Tests

  • Unit test
  • Integration test

Code changes

Side effects

Related changes

@lichunzhu
Copy link
Contributor Author

/run-all-tests

Copy link
Contributor

@suzaku suzaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@july2993 july2993 merged commit ca71e0d into pingcap:release-2.1 Aug 15, 2019
@lichunzhu lichunzhu deleted the czli/addSplitRegionTest branch September 2, 2019 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants