fix pump pull pop bug while closing pump #745
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
cherry-pick of #739
When we try to close pump server, we will cancel
s.ctx
first. But we wish thatstorage
will pull storaged binlogs until drainer receives them. Then pump can safely quit. But if we uses.ctx
forstorage.PullCommitBinlog
it will quit at first and drainer may no longer receive binlog from this pump.What is changed and how it works?
Change
s.ctx
tocontext.Background()
and adds.pullClose
channel to control the closure ofPullBinlogs
. Runclose(s.pullClose)
aftercommitStatus
.Check List
Tests
Code changes
Side effects
Related changes