Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binlogctl: Hide offline pumps/drainers by default #777

Merged
merged 2 commits into from
Nov 1, 2019

Conversation

suzaku
Copy link
Contributor

@suzaku suzaku commented Oct 22, 2019

What problem does this PR solve?

Cherry-pick #774

What is changed and how it works?

Only show offline pumps/drainers when -show-offline-nodes is set.

Check List

Tests

  • Manual test

Code changes

Side effects

Related changes

@suzaku
Copy link
Contributor Author

suzaku commented Oct 22, 2019

/run-all-tests pd=release-2.1 tidb=release-2.1 tikv=release-2.1

@suzaku
Copy link
Contributor Author

suzaku commented Oct 24, 2019

/run-all-tests pd=release-2.1 tidb=release-2.1 tikv=release-2.1

@suzaku
Copy link
Contributor Author

suzaku commented Oct 24, 2019

/run-all-tests

@suzaku
Copy link
Contributor Author

suzaku commented Oct 24, 2019

/rebuild

@suzaku
Copy link
Contributor Author

suzaku commented Oct 25, 2019

/run-integration-tests

Copy link
Contributor

@july2993 july2993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suzaku
Copy link
Contributor Author

suzaku commented Oct 30, 2019

/run-all-tests

Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@july2993 july2993 merged commit 098cb74 into pingcap:release-2.1 Nov 1, 2019
@suzaku suzaku deleted the hide-offline-2.1 branch November 1, 2019 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants