Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic of empty value in filter config (#799) #802

Merged
merged 1 commit into from
Nov 13, 2019

Conversation

july2993
Copy link
Contributor

Fix panic of empty value in filter config
Verify config about filters with empty schema or table name.

What problem does this PR solve?

cherry-pick #799

What is changed and how it works?

Fix panic of empty value in filter config
Verify config about filters with empty schema or table name.

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

  • Need to be included in the release note

Fix panic of empty value in filter config
Verify config about filters with empty schema or table name.
Copy link
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IANTHEREAL
Copy link
Collaborator

/run-all-tests

@IANTHEREAL
Copy link
Collaborator

LGTM

@july2993 july2993 merged commit d03b1f1 into pingcap:release-2.1 Nov 13, 2019
@july2993 july2993 deleted the filter_2.1 branch November 13, 2019 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants