fix deadlock while drainer.Syncer panic (#806) #807
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #806 to release-3.0
What problem does this PR solve?
we start
Syncer
goroutine indrainer
if
s.syncer
panic (like kafka producer panic),s.syncer.Start()
would exit directly and the logics will happens.syncer.Close()
ins.Close()
s.syncer.Close()
would wait<- s.syncer.closed
take effetcs,s.syncer.closed
only can be closed ins.syncer.run()
What is changed and how it works?
add
defer close(s.syncer.closed)
ins.syncer.run()
Check List