Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loader: don't refresh table info for some DDL (#613) #836

Merged
merged 2 commits into from
Dec 2, 2019
Merged

loader: don't refresh table info for some DDL (#613) #836

merged 2 commits into from
Dec 2, 2019

Conversation

zier-one
Copy link
Contributor

What problem does this PR solve?

cherry-pick #613

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the tidb-ansible repository
  • Need to be included in the release note

@july2993
loader/: don't refresh table info for some DDL (pingcap#613)
3988eb0 
* loader/: don't refresh table info for some DDL

* Trim use db as expect by loader.Txn
@suzaku
Copy link
Contributor

suzaku commented Dec 2, 2019

/run-all-tests

suzaku
suzaku reviewed Dec 2, 2019
View reviewed changes
Copy link
Contributor

@suzaku suzaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

IANTHEREAL
IANTHEREAL approved these changes Dec 2, 2019
View reviewed changes
Copy link
Collaborator

@IANTHEREAL IANTHEREAL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IANTHEREAL IANTHEREAL merged commit 3a9d27b into pingcap:release-2.1 Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suzaku suzaku suzaku left review comments

@IANTHEREAL IANTHEREAL IANTHEREAL approved these changes

Assignees
No one assigned
Labels
status/LGT2 type/cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zier-one @suzaku @IANTHEREAL @july2993