drainer: Fix #724, Enable drainer to purge old incremental backup data on disk #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suzaku
force-pushed
the
periodic-gc-for-file-sync
branch
from
338d67e
to
3edf281
Compare
|
/run-all-tests |
july2993
reviewed
Jan 21, 2020
|
/run-all-tests |
|
/run-integration-tests |
|
@july2993 PTAL |
IANTHEREAL
reviewed
Feb 4, 2020
IANTHEREAL
reviewed
Feb 4, 2020
|
Rest LGTM |
Co-Authored-By: Ian <ArGregoryIan@gmail.com>
Co-Authored-By: Ian <ArGregoryIan@gmail.com>
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| } | ||
|
|
||
| // NewPBSyncer sync binlog to files | ||
| func NewPBSyncer(dir string, tableInfoGetter translator.TableInfoGetter) (*pbSyncer, error) { | ||
| func NewPBSyncer(dir string, retentionDays int, tableInfoGetter translator.TableInfoGetter) (*pbSyncer, error) { |
There was a problem hiding this comment.
exported func NewPBSyncer returns unexported type *sync.pbSyncer, which can be annoying to use
| } | ||
|
|
||
| // NewPBSyncer sync binlog to files | ||
| func NewPBSyncer(dir string, tableInfoGetter translator.TableInfoGetter) (*pbSyncer, error) { | ||
| func NewPBSyncer(dir string, retentionDays int, tableInfoGetter translator.TableInfoGetter) (*pbSyncer, error) { |
There was a problem hiding this comment.
exported func NewPBSyncer returns unexported type *sync.pbSyncer, which can be annoying to use
|
/run-all-tests |
sokada1221
approved these changes
Feb 6, 2020
july2993
approved these changes
Feb 7, 2020
|
cherry pick to release-3.0 failed |
|
cherry pick to release-3.1 failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Enable drainer to purge old incremental backup data on disk.
What is changed and how it works?
retention-timeconfig to specify how long binlog files should be kept in drainer. Backward-compatibility is maintained by treating non-positive values ofretention-timeas no GC.retention-timeis of typeint, which is consistent with the pumpGCconfiguration. We may later introducep8sstyle time format for bothGCandretention-timeand use days as the default unit to maintain backward-compatibility.Check List
Tests
Code changes
Has exported function/method change
The
GCmethod is changed to two new methodsGCByTImeandGCByPos.Related changes