Refactor: Add TopologyProvider #1098
Conversation
…/move_httpclient/1_impl
…lient/2_topoprovider
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
| @@ -0,0 +1,3 @@ | |||
| module ignore_etc // a hack to ignore this directory in go commands | |||
There was a problem hiding this comment.
Explain it? I can't understand...
| resp, err := api.GetStores() | ||
| // HLGetStores returns all stores in PD in order. | ||
| // An optional ctx can be passed in to override the default context. To keep the default context, pass nil. | ||
| func (api *APIClient) HLGetStores(ctx context.Context) ([]GetStoresResponseStore, error) { |
There was a problem hiding this comment.
Is optional context a common usage in go? I always thought context was required.
There was a problem hiding this comment.
No. Context is always required. The full name of the parameter is overrideCtx context.Context here which makes it optional. Nil means not override and use the context specified in the client.
| return nil, err | ||
| } | ||
| _ = c.cache.Set(key, src) | ||
| runtime.KeepAlive(c) |
There was a problem hiding this comment.
Ok...This is too elaborate. Then we also need to be careful about using c.cache outside of getOrFillCache in the future.
There was a problem hiding this comment.
Probably won't use c.cache anymore.
There was a problem hiding this comment.
Yeah. Probably I should add a comment: Don't touch this unless you are professional about runtime.SetFinalizer behavior.. LOL
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: fc44582
|
* Revert "Release v2021.12.06.1 (#1084)" This reverts commit bcc43a0. * Compitable with different TiDB versions for conprof and non-root-login features (#1047) * make conprof independent * check feature enable * add check feature enable middleware * hide menu if feature is not enabled * refactor non root login switch by new design * i18n * yarn fmt * renaming * adjust fe code * refine * remove unused log * build(deps): bump ws from 5.2.2 to 5.2.3 in /ui (#1055) * CICD: Update the release pipeline for recent PD format policies (#1054) * fix i18n wording (#1056) * Refactor: Change util module to util package (#1052) * Refactor: Fix godot incorrectly add dot suffix to annotations (#1059) * lint: Add goheader for copyright lints (#1062) * Refactor: Migrate to use the `rest` package in util/ (#1060) * fix(*): globally delete/update data by GORM (#1065) * ui: bump dependencies (#1066) * refactor: Switch to use ziputil, netutil, reflectutil and fileswap (#1067) * Fix request header being pinned after pd profiling (#1069) * Integrate speedscope (#1064) * fix potential panic when GetPDInstances (#1075) Signed-off-by: crazycs <chen.two.cs@gmail.com> * Refactor: a new httpclient (#1073) * Refactor: Switch to use util/distro in all places (#1078) * chore: support import relative file URL (#1082) * Refactor: Move tools into a standalone module (#1079) * Fix script to embed the ui (#1088) * Fix script to embed the ui * Hack write_strings * Refactor feature flag to support more modules (#1057) * Drop sysutil dependency (#1093) * chore: add graph generation (#1085) * Refactor: Add TopologyProvider (#1098) * esbuild: i18n + dep (#1101) * script: Add a script to generate version matrix (#1104) * distro: support dynamic config (#1094) * chore: support multiple profiling types (#1095) * fix(distro): check distro_strings.json fmt by prettier (#1106) * script: fix generate assets (#1107) * Add integration test (#1083) * debug_api: Switch to use the new util (#1103) * refactor(ui): auto refresh button (#1105) * refactor(ui): auto refresh button * chore: update translation * fix: remain seconds * refine: refresh button * fix: onRefresh * fix: auto refresh * fix: continue tick * chore: add some comments * tweak: remaining refresh seconds * chore: clean code Co-authored-by: Wenxuan <breezewish@pingcap.com> * ui: refine conprof (#1102) * update wording * not check prom any more * replace time range component * i18n * support view profile by diffrent ways * extract ActionsButton * change download data format * refine * comments * Revert "comments" This reverts commit 3b03fdb. * fix view cpu profile fail * update state * hide action button if disable * address feedback * update release-version * sync with master Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Wenxuan <breezewish@pingcap.com> Co-authored-by: Suhaha <jklopsdfw@gmail.com> Co-authored-by: Yini Xu <34967660+YiniXu9506@users.noreply.github.com> Co-authored-by: crazycs <crazycs520@gmail.com>
To resolve #1050 in new utils elegantly, an interface called
TopologyProvideris introduced. Over which, there are two implementors:TopologyFromPD: A topology provider that provide topology from PDCachedTopology: A topology provider that caches the result of the underlying topology provider