ui: fix the error message doesn't show correct #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reason:
i18next.t() method will truncate some content and convert colons to dots if the content contains colons.
example:
i18next.t('Test: error message with colons: colons will become dots') => error message with colons. colons will become dots
baurine
force-pushed
the
fix-wrong-error-message
branch
from
b78d855 to
6b1af66
Compare
breezewish
reviewed
Nov 20, 2020
baurine
force-pushed
the
fix-wrong-error-message
branch
from
4453b31 to
b81a6cf
Compare
breezewish
approved these changes
Nov 21, 2020
|
Oh, sorry. I just realize that Consider that we have these translations: EN: err.code.xxx = "Xxx description". When we receive "err.code.xxx" and current language is CN, its translation exists, which is the EN fallback translation. However, in EN: abc = "Abc", abc_tooltip = "Abc Tooltip" In this case, we would like to show only "Abc 内容" when language is CN, instead of showing "Abc 内容" with an english "Abc Tooltip" tooltip. |
|
Got it, will revert it |
This reverts commit b81a6cf.
breezewish
approved these changes
Nov 23, 2020
breezewish
pushed a commit
that referenced
this pull request
Nov 26, 2020
breezewish
added a commit
that referenced
this pull request
Nov 26, 2020
* misc: Increase ulimit to 65535 for test env (#756) * test: Fix frontend CI (#752) * ui: fix dayjs i18n (#755) * ui: handle error globally (#757) * statement, slow_query: support all fields in list page (#749) * ui: memorize expand/collapse full text in detail pages (#775) * ui: break loop dependencies (#771) * ui: fix browser compatibility check (#776) * ui: Refine store location, add zoom and pan (#772) * ui: show disk usage information for statement and slow query (#777) * ui: use qps instead of ops (#786) * statement: support export (#778) *: Fix slow query and start_ts not working in some cases (#793) * ui: fix errors doesn't display (#794) * ui: fix the error message doesn't show correct (#799) * slow_queries: support export (#792) * ui: add MySqlFormatter to customize the sql formatter (#805) *: fix query statement detail error cause by round (#806) * ui: copy original content instead of formatted content for CopyLink (#802) * add min height of topology canvas (#804) * metrics: Support customize Prometheus address (#808) * clusterinfo: Refine (#815) * ui: Open statement and slow log in new tab (#816) * ui: add more time field for slow query detail page (#810) * slowlog: Improve descriptions (#817) * build: add action to check release-version is changed for release branch * Release v2020.11.26.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason:
i18next.t()method will truncate some contents and convert colons to dots if the content contains colons.Example:
We also refine the logic a bit. If errCode hasn't a translation, we show the original detail error message instead.