This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
/run-all-tests |
/run-integration-test |
kennytm
reviewed
Dec 21, 2018
kennytm
reviewed
Dec 21, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
PTAL @csuzhangxc
LGTM |
winkyao
approved these changes
Dec 21, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
status/LGT2
Two reviewers already commented LGTM, ready for merge (LGTM2)
type/enhancement
Performance improvement or refactoring
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
restore: reuse bytes.Buffer in
chunk.restore
benchmark (SQL file: 1529669bytes ~1.5KB, Chunk size: 64KB, Rows: 223):
tidb-lightning/lightning/restore/restore_test.go
Line 55 in be8eb67
benchmark (SQL file: 1GB, Chunk size: 64KB):
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes