Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

config: reduce default table-concurrency from 8 to 6 #175

Merged
merged 1 commit into from
Apr 30, 2019
Merged

config: reduce default table-concurrency from 8 to 6 #175

merged 1 commit into from
Apr 30, 2019

Conversation

kennytm
Copy link
Collaborator

@kennytm kennytm commented Apr 27, 2019

What problem does this PR solve?

The current default table-concurrency is 8, meaning up to 8 data engines will be opened. Then the default index-concurrency is 2, so together up to 10 engines will be opened. But Importer's default max-open-engine is 8, so with the default settings we will hit the TooManyOpenEngines error.

What is changed and how it works?

Reduce the default table-concurrency to 6.

Check List

Tests

  • No code

Side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the tidb-ansible repository

@kennytm
config: reduce default table-concurrency from 8 to 6
272d967 
Ensures table + index <= the default max-open-engine which is 8.
@kennytm kennytm added priority/unimportant Should Cherry-pick This PR should be cherry-picked back the previous release train Should Update Ansible The config in TiDB-Ansible should be updated status/PTAL This PR is ready for review. Add this label back after committing new changes labels Apr 27, 2019
@kennytm kennytm mentioned this pull request Apr 27, 2019
Merged
@kennytm
Copy link
Collaborator Author

kennytm commented Apr 27, 2019

/run-all-tests tidb=master tikv=master pd=master

@IANTHEREAL
Copy link
Collaborator

LGTM

@IANTHEREAL IANTHEREAL added status/LGT1 One reviewer already commented LGTM (LGTM1) and removed Should Cherry-pick This PR should be cherry-picked back the previous release train labels Apr 28, 2019
@kennytm
Copy link
Collaborator Author

kennytm commented Apr 28, 2019

PTAL @lonng

lonng
lonng approved these changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lonng lonng added status/LGT2 Two reviewers already commented LGTM, ready for merge (LGTM2) and removed status/LGT1 One reviewer already commented LGTM (LGTM1) status/PTAL This PR is ready for review. Add this label back after committing new changes labels Apr 30, 2019
@lonng lonng merged commit 889ce1b into master Apr 30, 2019
@lonng lonng deleted the kennytm/reduce-default-table-conc branch April 30, 2019 02:17
@kennytm kennytm removed the Should Update Ansible The config in TiDB-Ansible should be updated label May 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lonng lonng lonng approved these changes

Assignees
No one assigned
Labels
status/LGT2 Two reviewers already commented LGTM, ready for merge (LGTM2)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kennytm @IANTHEREAL @lonng