This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
checkpoint: fix empty map become nil after unmarshall #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lance6716
added
priority/normal
Should Cherry-pick
IANTHEREAL
reviewed
Sep 6, 2019
| log.L().Error("checkpoint file is broken", zap.String("path", path), zap.Error(err2)) | ||
| } | ||
| // FIXME: patch for empty map may need initialize manually, because currently | ||
| // FIXME: a map of zero size -> marshall -> unmarshall -> become nil, see checkpoint_test.go |
There was a problem hiding this comment.
why using FIXME for these comments?
There was a problem hiding this comment.
I think it's an unexpected behaviour of gogo/protobuf's marshall and unmarshall. There's logic to recover a empty map(but didn't execute) in
tidb-lightning/lightning/checkpoints/file_checkpoints.pb.go
Lines 877 to 878 in d49fec6
If gogo/protobuf fixed this bug, we won't bother to initiate. So I added a FIXME to remind to report bug and check if fixed from gogo/protobuf.
|
Rest LGTM |
|
/run-all-tests |
|
LGTM |
lance6716
added
status/LGT1
kennytm
approved these changes
Sep 6, 2019
kennytm
added
status/LGT2
lance6716
added a commit
that referenced
this pull request
Sep 6, 2019
* checkpoint: fix empty map become nil after unmarshall * checkpoint: unify code style * checkpoint: remove hard-coded path
lance6716
added a commit
that referenced
this pull request
Sep 6, 2019
lance6716
added a commit
that referenced
this pull request
Sep 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix empty map become nil after marshall and unmarshall
What is changed and how it works?
manually init these map. Seems it's a bug of marshall function provided by gogoproto.
Check List
Tests
Side effects
Related changes