Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

config: adding [tidb] max-allowed-packet config #248

Merged
merged 1 commit into from
Nov 20, 2019
Merged

config: adding [tidb] max-allowed-packet config #248

merged 1 commit into from
Nov 20, 2019

Conversation

kennytm
Copy link
Collaborator

@kennytm kennytm commented Nov 19, 2019

this allows sending rows > 4 MiB when using TiDB backend

What problem does this PR solve?

Expose the maxAllowedPacket DSN parameter to tidb-lightning.toml (perhaps we should just accept arbitrary DSNs 🤷‍♂)

What is changed and how it works?

  • Accept the [tidb] max-allowed-packet = 67_108_864 config.
  • When constructing the DSN to TiDB, include this value into the parameters.

Check List

Tests

  • Unit test

Side effects

Related changes

  • Need to update the documentation (document the new config)
  • Need to update the tidb-ansible repository (add the new config to the templates)
  • Need to be included in the release note (?)

@kennytm kennytm added Should Update Docs Should update docs after this PR is merged. Remove this label once the docs are updated Should Update Ansible The config in TiDB-Ansible should be updated labels Nov 19, 2019
@kennytm
config: adding [tidb] max-allowed-packet config
c093739 
this allows sending rows > 4 MiB when using TiDB backend
@kennytm kennytm force-pushed the kennytm/max-allowed-packets branch from 80cb579 to c093739 Compare November 19, 2019 07:06
@kennytm
Copy link
Collaborator Author

kennytm commented Nov 19, 2019

/run-all-tests

@kennytm kennytm added status/PTAL This PR is ready for review. Add this label back after committing new changes type/enhancement Performance improvement or refactoring labels Nov 19, 2019
@kennytm
Copy link
Collaborator Author

kennytm commented Nov 19, 2019

PTAL @3pointer @GregoryIan

@kennytm kennytm added status/LGT1 One reviewer already commented LGTM (LGTM1) and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Nov 19, 2019
@WangXiangUSTC
Copy link
Contributor

LGTM

@WangXiangUSTC WangXiangUSTC added status/LGT2 Two reviewers already commented LGTM, ready for merge (LGTM2) and removed status/LGT1 One reviewer already commented LGTM (LGTM1) labels Nov 20, 2019
@kennytm kennytm merged commit 605760d into master Nov 20, 2019
@kennytm kennytm deleted the kennytm/max-allowed-packets branch November 20, 2019 08:25
@kennytm kennytm removed the Should Update Docs Should update docs after this PR is merged. Remove this label once the docs are updated label Dec 7, 2019
@kennytm kennytm mentioned this pull request Dec 7, 2019
Merged
@anotherrachel anotherrachel mentioned this pull request Jan 14, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@3pointer 3pointer 3pointer approved these changes

Assignees
No one assigned
Labels
Should Update Ansible The config in TiDB-Ansible should be updated status/LGT2 Two reviewers already commented LGTM, ready for merge (LGTM2) type/enhancement Performance improvement or refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kennytm @WangXiangUSTC @3pointer