This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 66
config: synchronize actual default value with the toml file #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytm
added
Should Update Docs
Should update docs after this PR is merged. Remove this label once the docs are updated
status/PTAL
This PR is ready for review. Add this label back after committing new changes
priority/unimportant
type/feature
New feature
labels
Jan 8, 2020
kennytm
force-pushed
the
kennytm/align-default-config
branch
from
January 8, 2020 15:56
8b9a9d5
to
a3edd5d
Compare
/run-all-tests |
PTAL @GregoryIan |
/run-all-tests |
Ping @GregoryIan |
PTAL @WangXiangUSTC @3pointer |
LGTM (from community) |
/run-all-tests (Exposed --check-requirements to command line too.) |
3pointer
approved these changes
Feb 4, 2020
kennytm
added
status/LGT2
Two reviewers already commented LGTM, ready for merge (LGTM2)
and removed
status/PTAL
This PR is ready for review. Add this label back after committing new changes
labels
Feb 4, 2020
kennytm
removed
the
Should Update Docs
Should update docs after this PR is merged. Remove this label once the docs are updated
label
Jun 17, 2020
5 tasks
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Make the default values when missing a config file to be equivalent to the default TOML file.
Exposed a few settings in command line.
What is changed and how it works?
Changed default values:
Exposed global / command line options:
Check List
Tests
bin/tidb-lightning --analyze=true
,bin/tidb-lightning --analyze=false
, etc.Side effects
Related changes