-
Notifications
You must be signed in to change notification settings - Fork 66
Support TLS; Reduce the need of config.toml in integration tests #270
Conversation
refactored the tests so only essential settings remained in config.toml
4a876f4
to
cc67957
Compare
The `curl` on CI is too old to handle ECC keys. But `wget` somehow works.
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
there are two kind of security, |
Only SQL connection uses |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
Fix #262.
What is changed and how it works?
Code changes:
[security]
section in the config to read CA, cert and key. These are used to construct the standard*tls.Config
.tls
parameter in the DSN)common.TLS
for simplified management. This struct mainly acts as anhttp.Client
to fetch JSON objects, plus methods to produce options for securing gRPC and MySQL protocols.Test changes:
tidb-lightning
andtidb-lightning-ctl
invocations. To simplify future changes, therun_lightning
andrun_lightning_ctl
helper scripts now define most common settings in the command line.config.toml
s are simplified to retain only the essential settings.Check List
Tests
Side effects
Related changes
tidb-ansible
repository