Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

config: remove strict mode from default SQL mode #316

Merged
merged 3 commits into from
May 11, 2020
Merged

config: remove strict mode from default SQL mode #316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c81a1fe
config: remove strict mode from default SQL mode
kennytm May 11, 2020
9485288
tests: fixed typo
kennytm May 11, 2020
f583f78
Merge branch 'master' into kennytm/no-strict-mode
lichunzhu May 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lightning/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ func NewConfig() *Config {
Host: "127.0.0.1",
User: "root",
StatusPort: 10080,
StrSQLMode: mysql.DefaultSQLMode,
StrSQLMode: "ONLY_FULL_GROUP_BY,NO_AUTO_CREATE_USER",
MaxAllowedPacket: defaultMaxAllowedPacket,
BuildStatsConcurrency: 20,
DistSQLScanConcurrency: 100,
Expand Down
2 changes: 2 additions & 0 deletions tests/sqlmode/on.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[tidb]
sql-mode = 'STRICT_TRANS_TABLES'