This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
Support table routing rules (merging sharded tables) #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytm
added
status/DNM
|
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
|
/run-all-tests |
kennytm
force-pushed
the
kennytm/shard-merging
branch
2 times, most recently
from
e736496
to
5b1aaf1
Compare
kennytm
force-pushed
the
kennytm/shard-merging
branch
from
5b1aaf1
to
a9138d2
Compare
|
/run-all-tests |
kennytm
removed
the
status/DNM
kennytm
changed the title
|
/run-integration-test |
kennytm
added
the
status/PTAL
kennytm
force-pushed
the
kennytm/shard-merging
branch
from
a9138d2
to
71b6aeb
Compare
|
PTAL @july2993 @csuzhangxc |
kennytm
force-pushed
the
kennytm/shard-merging
branch
from
71b6aeb
to
f013ac5
Compare
kennytm
added
status/WIP
csuzhangxc
reviewed
Apr 15, 2019
csuzhangxc
reviewed
Apr 16, 2019
kennytm
force-pushed
the
kennytm/shard-merging
branch
from
f013ac5
to
c40d6c6
Compare
IANTHEREAL
reviewed
Apr 29, 2019
IANTHEREAL
reviewed
Apr 29, 2019
|
/run-all-tests tidb=master tikv=master pd=master |
|
LGTM |
|
@csuzhangxc @lonng PTAL |
IANTHEREAL
added
status/LGT1
|
Is there any problem with CI? |
|
There's a bug in Edit: filed pingcap/parser#310 |
|
/run-all-tests tidb=master tikv=master pd=master |
This comment has been minimized.
This comment has been minimized.
kennytm
force-pushed
the
kennytm/shard-merging
branch
from
b9fcb0e
to
907708b
Compare
|
/run-all-tests tidb=release-3.0 tikv=release-3.0 pd=release-3.0 |
|
/run-all-tests tidb=release-2.1 tikv=release-2.1 pd=release-2.1 |
|
I think we've got a TiDB regression from 2.1 to 3.0. Edit: Reproduced locally, it's a master→master regression. |
csuzhangxc
added
status/LGT2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
TOOL-142
(Note: still won't handle UNIQUE/PRIMARY key conflict. This needs column-mapping)
What is changed and how it works?
Rename the tables while the loading the files. Since we don't care about the table name when parsing the data files, it becomes very simple to support merging: just associate all those data files to the target table.
This PR supersedes #54. Note that #54 is very large because it attempts to do some refactoring at the same time.
Check List
Tests
Code changes
Side effects
Related changes