-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suspend ReplaceUnhealthy process for AWS tikv auto-scaling-group #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aylei <rayingecho@gmail.com>
/run-e2e-in-kind |
tennix
approved these changes
Oct 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-e2e-in-kind |
/run-e2e-in-kind |
cherry pick to release-1.0 in PR #1027 |
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
…1014) * zh: add the doc about migrating to Helm3 * zh: update commands for Helm3 * zh: mirror refine * zh: address comments * zh: address comments * zh: address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/terraform
cloud/aws
Amazon Web Services
needs-cherry-pick-1.0
status/PTAL
PR needs to be reviewed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
close #962
What is changed and how does it work?
Add suspended_processes definition for tikv asg.
Compatibility: This update is in-place, so if a user upgrade an existing cluster to adopt this change, the ec2 instances won't get affected.
Check List
Does this PR introduce a user-facing change?:
@weekface @tennix @cofyc PTAL