Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suspend ReplaceUnhealthy process for AWS tikv auto-scaling-group #1014

Merged
merged 6 commits into from
Oct 18, 2019

Conversation

aylei
Copy link
Contributor

@aylei aylei commented Oct 15, 2019

What problem does this PR solve?

close #962

What is changed and how does it work?

Add suspended_processes definition for tikv asg.

Compatibility: This update is in-place, so if a user upgrade an existing cluster to adopt this change, the ec2 instances won't get affected.

Check List

  • Manual test (add detailed scripts or steps below)

Does this PR introduce a user-facing change?:

Suspend ReplaceUnhealthy process for AWS tikv auto-scaling-group

@weekface @tennix @cofyc PTAL

@aylei aylei requested review from weekface, cofyc and tennix October 15, 2019 08:51
Signed-off-by: Aylei <rayingecho@gmail.com>
@cofyc
Copy link
Contributor

cofyc commented Oct 15, 2019

/run-e2e-in-kind

@tennix tennix added area/terraform cloud/aws Amazon Web Services labels Oct 15, 2019
@aylei aylei added the status/PTAL PR needs to be reviewed label Oct 15, 2019
Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aylei
Copy link
Contributor Author

aylei commented Oct 17, 2019

/run-e2e-in-kind

@cofyc
Copy link
Contributor

cofyc commented Oct 18, 2019

/run-e2e-in-kind

@sre-bot
Copy link
Contributor

sre-bot commented Oct 18, 2019

cherry pick to release-1.0 in PR #1027

yahonda pushed a commit that referenced this pull request Dec 27, 2021
…1014)

* zh: add the doc about migrating to Helm3

* zh: update commands for Helm3

* zh: mirror refine

* zh: address comments

* zh: address comments

* zh: address comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suspend ReplaceUnhealthy process for AWS tikv auto-scaling-group
4 participants