Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidb loadbalancer output is empty after terraform apply #1045

Merged
merged 4 commits into from
Oct 25, 2019
Merged

tidb loadbalancer output is empty after terraform apply #1045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
62aee4c
tidb lb is empty after terraform apply
DanielZhangQD Oct 23, 2019
93b3cb6
update scheduler image for ali and lb key for gcp
DanielZhangQD Oct 23, 2019
59fde59
wait for monitoring lb
DanielZhangQD Oct 24, 2019
d630e7e
Merge branch 'master' into lb
DanielZhangQD Oct 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions deploy/modules/aliyun/tidb-operator/operator.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,6 @@ resource "helm_release" "tidb-operator" {

set {
name = "scheduler.kubeSchedulerImageName"
value = "gcr.akscn.io/google_containers/hyperkube"
value = "registry.cn-hangzhou.aliyuncs.com/google_containers/kube-scheduler-amd64"
}
}
}
1 change: 1 addition & 0 deletions deploy/modules/gcp/tidb-cluster/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ module "tidb-cluster" {
kubeconfig_filename = var.kubeconfig_path
base_values = file("${path.module}/values/default.yaml")
wait_on_resource = [google_container_node_pool.tidb_pool, var.tidb_operator_id]
service_ingress_key = "ip"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tidb-cluster-release is used in gcp, aliyun and aws. why this variable is only set for gcp?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already set in aliyun and aws.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, I see. other platforms use its default value.

}

resource "null_resource" "wait-lb-ip" {
Expand Down
4 changes: 2 additions & 2 deletions deploy/modules/share/tidb-cluster-release/data.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
data "external" "tidb_hostname" {
depends_on = [helm_release.tidb-cluster]
depends_on = [helm_release.tidb-cluster, null_resource.wait-lb-ip]
working_dir = path.cwd
program = ["bash", "-c", "kubectl --kubeconfig ${var.kubeconfig_filename} get svc -n ${var.cluster_name} ${var.cluster_name}-tidb -o json | jq '.status.loadBalancer.ingress[0]'"]
}

data "external" "monitor_hostname" {
depends_on = [helm_release.tidb-cluster]
depends_on = [helm_release.tidb-cluster, null_resource.wait-mlb-ip]
working_dir = path.cwd
program = ["bash", "-c", "kubectl --kubeconfig ${var.kubeconfig_filename} get svc -n ${var.cluster_name} ${var.cluster_name}-grafana -o json | jq '.status.loadBalancer.ingress[0]'"]
}
Expand Down
44 changes: 44 additions & 0 deletions deploy/modules/share/tidb-cluster-release/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,3 +139,47 @@ EOS
}
}
}

resource "null_resource" "wait-lb-ip" {
depends_on = [
helm_release.tidb-cluster
]
provisioner "local-exec" {
interpreter = ["bash", "-c"]
working_dir = path.cwd
command = <<EOS
set -euo pipefail

until kubectl get svc -n ${var.cluster_name} ${var.cluster_name}-tidb -o json | jq '.status.loadBalancer.ingress[0]' | grep "${var.service_ingress_key}"; do
echo "Wait for TiDB internal loadbalancer IP"
sleep 5
done
EOS

environment = {
KUBECONFIG = var.kubeconfig_filename
}
}
}

resource "null_resource" "wait-mlb-ip" {
depends_on = [
helm_release.tidb-cluster
]
provisioner "local-exec" {
interpreter = ["bash", "-c"]
working_dir = path.cwd
command = <<EOS
set -euo pipefail

until kubectl get svc -n ${var.cluster_name} ${var.cluster_name}-grafana -o json | jq '.status.loadBalancer.ingress[0]' | grep "${var.service_ingress_key}"; do
echo "Wait for TiDB monitoring internal loadbalancer IP"
sleep 5
done
EOS

environment = {
KUBECONFIG = var.kubeconfig_filename
}
}
}