Fix create_tidb_cluster_release variable does not work #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aylei <rayingecho@gmail.com>
DanielZhangQD
approved these changes
Oct 29, 2019
| @@ -22,6 +23,7 @@ data "helm_repository" "pingcap" { | |||
| } | |||
|
|
|||
| resource "helm_release" "tidb-cluster" { | |||
| count = var.create ? 1 : 0 | |||
There was a problem hiding this comment.
The '=' should be aligned with others in the same block.
Same comments for the other updates in this file.
There was a problem hiding this comment.
I think we need to add Terraform fmt and validate to CI.
There was a problem hiding this comment.
There is already an issue tracking this #823
There was a problem hiding this comment.
if there's a blank line between, then the = don't have to be aligned
|
cherry pick to release-1.0 in PR #1066 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aylei rayingecho@gmail.com
What problem does this PR solve?
close #1057
Check List
Tests
Related changes
Does this PR introduce a user-facing change?:
@DanielZhangQD @tennix @cofyc PTAL