Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tkctl version does not work when the release name is un-wan… #1065

Merged
merged 3 commits into from
Oct 29, 2019
Merged

Fix tkctl version does not work when the release name is un-wan… #1065

merged 3 commits into from
Oct 29, 2019

Conversation

aylei
Copy link
Contributor

@aylei aylei commented Oct 29, 2019

Signed-off-by: Aylei rayingecho@gmail.com

What problem does this PR solve?

#1028

Check List

Tests

  • Manual test (add detailed scripts or steps below)
./tkctl version
Client Version: v1.1.0-alpha.1.87+461bffe0599abb-dirty
TiDB Controller Manager Version: hub.pingcap.net/schrodinger/tidb-operator:latest
TiDB Scheduler Version:
	tidb-scheduler: hub.pingcap.net/schrodinger/tidb-operator:latest
	kube-scheduler: k8s.gcr.io/kube-scheduler:v1.12.9

Does this PR introduce a user-facing change?:

Fix tkctl version does not work when the release name is un-wanted

@aylei
Fix tkctl version does not work when the release name is un-wanted
4e4ffaf 
Signed-off-by: Aylei <rayingecho@gmail.com>
@cofyc
Copy link
Contributor

cofyc commented Oct 29, 2019

I think we should add some tests for tkctl now.

weekface
weekface approved these changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@weekface weekface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tennix
tennix approved these changes Oct 29, 2019
View reviewed changes
Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tennix tennix changed the title Fix tkctl version does not work when the release name is un-wanted Fix tkctl version does not work when the release name is un-wan… Oct 29, 2019
@tennix tennix merged commit cd96a78 into pingcap:master Oct 29, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 29, 2019

cherry pick to release-1.0 failed

@aylei aylei mentioned this pull request Oct 30, 2019
Merged
@aylei aylei mentioned this pull request Nov 11, 2019
Closed
yahonda pushed a commit that referenced this pull request Dec 27, 2021
@dragonly @ran-huang
en, zh: add tikv conf for using br with pv (#1065)
7ba9429 
* add tikv conf for using br with pv

* Apply suggestions from code review

Co-authored-by: Ran <huangran@pingcap.com>

* Apply suggestions from code review

* Update zh/backup-to-pv-using-br.md

Co-authored-by: Ran <huangran@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tennix tennix tennix approved these changes

@weekface weekface weekface approved these changes

@cofyc cofyc Awaiting requested review from cofyc

@Yisaer Yisaer Awaiting requested review from Yisaer

Assignees
No one assigned
Labels
area/cli Related to tkctl needs-cherry-pick-1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aylei @cofyc @sre-bot @weekface @tennix